Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring @gmponos PR forward with master #668

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

jameswilddev
Copy link

This is identical to #520 but caught up with master.

@jameswilddev
Copy link
Author

Right, got that to pass everything but the mutation tests. I don't really know how to fix those (a lot of what it flags isn't stuff I've changed).

@frederikbosch
Copy link
Member

Great work @jameswilddev and @gmponos (!). To what extend is the exponential parser also able to parse normal numbers?

@jameswilddev
Copy link
Author

I'll be honest I haven't looked at the base PR in depth; I've only checked out the branch, merged master and fixed CI failures.

In my case I'm maintaining a product which uses Money and found a bug where entering "1e1" would get past validation, but then cause a parser error and figured this could well be fix.

@frederikbosch
Copy link
Member

What is the use again of this Parser/Formatter? Maybe it is time to merge this in after 4 years..... sorry guys!

@gmponos
Copy link
Contributor

gmponos commented Dec 16, 2022

What is the use again of this Parser/Formatter? Maybe it is time to merge this in after 4 years..... sorry guys!

Hi, haven't fully understood the question.

  • We haven't submitted a formatter..
  • The use cases are on the tests.

Not sure if I miss something.. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants